Dear Leo, Thanks for your work and this Github repository! I agree that my failure to incorporate patches into the main CVS repository at a reasonable pace has been a problem. I'll try harder.
Your repository might have code changes that are a bit too aggressive for my comfort zone at this point, but I'll try to reduce the gap by reviewing the various patches and making a new release in finite time. (I know, it's not the first time I say this). Thanks again for your contributions. Best, Denis On 01/10/2012 04:24 PM, Leo Alekseyev wrote: > Hi everyone, > > First, I want to thank Denis and Andreas for writing, maintaining, and > rewriting an awesome cross-platform inking application. It is very > liberating not to have to use Windows when working with digital ink. > > I used Windows Journal extensively over the last four years as I was > completing my PhD. The reason I didn't switch to Xournal until > recently was, in part, due to the fact that it missed a few features > that I have grown very used to in Windows Journal. Key among them > were the lasso tool and image support. I often insert plots and other > clippings into my notes, and I often copy/paste strokes that are in > close proximity to other strokes, so having both image and lasso tools > was important. Thus, I got to work modifying code and applying > patches. The result is up on github at > https://github.com/leoalekseyev/xournal. I would very much welcome > any feedback and / or bug reports. > > In my current branch, the following patches were applied: > > 1. Image support: I had written most of my own image-handling code, > starting with Victor Saase's insert image patch, before remembering > that Simon Guest had written a comprehensive image patch. I used > Simon's PDF-exporting code, changed to his way of serializing images; > overall, our patches should be quite similar. I'd welcome testing > and/or code review of the patch (particularly from Simon). > > 2. Lasso patch from Ian-Woo Kim: I found that it triggers a bug in > libgnomecanvas that resulted in segfaults. I've isolated that bug and > dropped in a fixed version of the broken function. Some code was > refactored to maximize reuse between rectangle and lasso selection. > > 3. Autosave: I modified Timo Kluck's modification of code from Edward > Z. Yang and Paulo Neves. Autosaves are now stored in central > location; in addition, autosave now works on Windows (PIDs are > obtained from Windows process API via psapi.dll). > > 4. I included the updated automake files and Windows build > instructions from Georg Wechslberger > (https://github.com/tauu/xournal/) to improve the build process on > Windows. > > 5. My starting point for Xournal hacking was Daniel German's github > branch (https://github.com/dmgerman/xournal), so all of his > modifications in the current master branch are included. > > The following features were added by me: > > - resize selection improvements: > 1. fixed aspect ratio when resizing selection by dragging its corner > 2. larger margin for grabbing a corner handle > 3. (cosmetic) added small selection box padding > > - pressing stylus button-2 and dragging duplicates selection > > In the process of writing the image patch, I've done the following code > cleanup: > > - Separated out image, selection, and clipboard functionality into > their own files (xo-image.c, xo-selection.c, xo-clipboard.c). > > - Put include guards into all headers. > > - Refactored much of the clipboard copy/paste code. > > These changes are described in a bit more detail in the README > (https://github.com/leoalekseyev/xournal/blob/master/README.org). > > I intend to keep maintaining this branch and would be happy to accept > pull requests from people. In particular, I'd love to see more of the > functionality that currently exists in the form of patches on > Sourceforge integrated into my current codebase. > > In closing, I'd like to remind everyone that has ever worked on > Xournal that people really appreciate this piece of software and enjoy > using it -- just look at the comments of the sourceforge project page. > It looks good, works well, is stable, is cross-platform, and can give > Windows Journal a run for its money. But you can also see frustration > with the fact that many features are scattered across different > patches. It would be nice to have a beta or a dev branch of Xournal, > where we could push our patches, maintaining a consistent version for > everyone. If this is too difficult to arrange on Sourceforge, I > propose my github branch as such a venue, as it currently seems to > have the most patches in it, including the often-requested image and > lasso support. > > Check it out, test it, let me know what you think! > > Wishing everyone a Happy (belated) New Year, > > --Leo Alekseyev > > ------------------------------------------------------------------------------ > Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex > infrastructure or vast IT resources to deliver seamless, secure access to > virtual desktops. With this all-in-one solution, easily deploy virtual > desktops for less than the cost of PCs and save 60% on VDI infrastructure > costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox > _______________________________________________ > Xournal-devel mailing list > Xournal-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/xournal-devel -- Denis Auroux University of California, Berkeley aur...@math.berkeley.edu Department of Mathematics Tel: 510-642-4367 817 Evans Hall # 3840 Fax: 510-642-8204 Berkeley, CA 94720-3840 ------------------------------------------------------------------------------ RSA(R) Conference 2012 Mar 27 - Feb 2 Save $400 by Jan. 27 Register now! http://p.sf.net/sfu/rsa-sfdev2dev2 _______________________________________________ Xournal-devel mailing list Xournal-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xournal-devel
