Looks good and straightforward enough, and it addresses a frequent complaint of non-tablet users. It's now included in cvs and git repositories after some tiny changes (I kept the location of the option in the Options menu as in the new patch, but still call the variable ui.pen_cursor as in the first version; I updated the glade file so it still generates xo-interface.c).
Let me know if there's any problem with what I committed (didn't have time to triple-check my work as usual). Denis On 11/07/2012 01:54 PM, Luciano Siqueira wrote: > You're right. In this new patch, I moved the Pencil Cursor option to > the Options menu. > > If you'll use it, don't forget to revert the previous patch. > > Thanks! > > 2012/11/7 dmg <d...@uvic.ca>: >> I just checked, and you did indeed modify the config file. Great! >> >> On Wed, Nov 7, 2012 at 9:53 AM, dmg <d...@uvic.ca> wrote: >>> Hi Luciano, >>> >>> I am not the offiicial maintainer, but I have two recommendations to >>> make this patch better: >>> >>> 1. Move it to options. I should not be part of the tool, since it does >>> not alter its behaviour (it is only aesthetic). >>> 2. Have you implemented saving the option to the config file? >>> >>> --dmg >>> >>> >>> On Wed, Nov 7, 2012 at 5:57 AM, Luciano Antonio Siqueira >>> <lcn...@gmail.com> wrote: >>>> Hi folks. I'm using Xournal for a while and I think it's an amazing >>>> software. >>>> >>>> However, it was hard for me to follow the dot as the pen cursor. So I >>>> wrote a >>>> patch to the git source code as of 2012/11/07. >>>> >>>> It adds an option to the "Tools" menu (screenshot attached), to change the >>>> pen >>>> cursor to the "pencil" cursor found in the system mouse theme. >>>> >>>> Hope it can be merged to the main code tree so I can get back to te >>>> official >>>> Fedora package :) >>>> >>>> Cheers >>>> ------------------------------------------------------------------------------ >>>> LogMeIn Central: Instant, anywhere, Remote PC access and management. >>>> Stay in control, update software, and manage PCs from one command center >>>> Diagnose problems and improve visibility into emerging IT issues >>>> Automate, monitor and manage. Do more in less time with Central >>>> http://p.sf.net/sfu/logmein12331_d2d >>>> _______________________________________________ >>>> Xournal-devel mailing list >>>> Xournal-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/xournal-devel >>>> >>> >>> >>> >>> -- >>> --dmg >>> >>> --- >>> Daniel M. German >>> http://turingmachine.org >> >> >> >> -- >> --dmg >> >> --- >> Daniel M. German >> http://turingmachine.org >> >> >> ------------------------------------------------------------------------------ >> LogMeIn Central: Instant, anywhere, Remote PC access and management. >> Stay in control, update software, and manage PCs from one command center >> Diagnose problems and improve visibility into emerging IT issues >> Automate, monitor and manage. Do more in less time with Central >> http://p.sf.net/sfu/logmein12331_d2d >> >> >> _______________________________________________ >> Xournal-devel mailing list >> Xournal-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/xournal-devel -- Denis Auroux aur...@math.berkeley.edu University of California, Berkeley Tel: 510-642-4367 Department of Mathematics Fax: 510-642-8204 817 Evans Hall # 3840 Berkeley, CA 94720-3840 ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov _______________________________________________ Xournal-devel mailing list Xournal-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xournal-devel
