Hi Denis,
There is a bug in the "Save Journal" option of xournal under Windows.
How to reproduce:
- Set xournal default path to any meaningful path
- Start xournal
- Try to save current unnamed xournal document to a file
The dialog window will show the <last segment of the path>/<basename>
This patch fixed it. It will also fix a compilation error (use g_mkdir
instead of mkdir).
By the way, are you already in github? If so i can issue a pull-request.
--dmg
commit 03a46e408c965cb2422d5611437d42dc0d483990
Author: Daniel M German <d...@uvic.ca>
Date: Mon Aug 25 20:16:43 2014 -0700
fixed minors filesystem issues under windows
diff --git a/src/main.c b/src/main.c
index c05bc1a..4348e87 100644
--- a/src/main.c
+++ b/src/main.c
@@ -57,7 +57,7 @@ void init_stuff (int argc, char *argv[])
// initialize config file names
tmppath = g_build_filename(g_get_home_dir(), CONFIG_DIR, NULL);
- mkdir(tmppath, 0700); // safer (MRU data may be confidential)
+ g_mkdir(tmppath, 0700); // safer (MRU data may be confidential)
ui.mrufile = g_build_filename(tmppath, MRU_FILE, NULL);
ui.configfile = g_build_filename(tmppath, CONFIG_FILE, NULL);
g_free(tmppath);
diff --git a/src/xo-misc.c b/src/xo-misc.c
index 948a57d..195072b 100644
--- a/src/xo-misc.c
+++ b/src/xo-misc.c
@@ -82,7 +82,7 @@ gchar *candidate_save_filename(void)
curtime = time(NULL);
strftime(stime, 30, "%Y-%m-%d-Note-%H-%M.xoj", localtime(&curtime));
if (ui.default_path!=NULL)
- return g_strdup_printf("%s/%s", ui.default_path, stime);
+ return g_strdup_printf("%s%c%s", ui.default_path, G_DIR_SEPARATOR, stime);
else return g_strdup(stime);
}
--
Daniel M. German "Speak not about what you have read,
Azerbaijani Proverb -> but about what you have understood."
http://turingmachine.org/
http://silvernegative.com/
dmg (at) uvic (dot) ca
replace (at) with @ and (dot) with .
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Xournal-devel mailing list
Xournal-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xournal-devel
