Hi Denis,

I have fixed the issues of the missing dialogs. Sorry I didn't test
them.

I have rebased my branch to have one single commit with the changes. It
includes renaming the xournal.glade file to xournal.ui.

https://github.com/dmgerman/xournal/tree/glade

the patch is browsable here:

https://github.com/dmgerman/xournal/commit/3a83c02469c017acc5a7899983e8011f83d98381

One thing that I noticed. There is inconsistency between the zoom dialog
and the paper dialog. Only zoom has a Cancel button.

But I think than Cancel is not doing what is expected (which is to
revert the changes to before the dialog was open). It behaves as if the
user pressed ok.

what do you think? should we make cancel have a more standard behaviour?

--dmg


--
Daniel M. German                  "No iron can stab the heart
                                   with such force as a full
    Isaac Babel ->                 stop put just at the right place."
http://turingmachine.org/
http://silvernegative.com/
dmg (at) uvic (dot) ca
replace (at) with @ and (dot) with .

 

------------------------------------------------------------------------------
_______________________________________________
Xournal-devel mailing list
Xournal-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xournal-devel

Reply via email to