Hi Daniel, Regarding width change of variable-width strokes, I actually have thought about it and my conclusion was to not add menu options, but instead make it so that:
- if the selection contains strokes whose nominal brush width is not the one that the user asks to change to, then we rescale all variable-widths proportionally (by ratio of new nominal brush width to old one). This is presumably what you implemented. - otherwise, i.e. all selected strokes are already at the requisite nominal brush width, hence doing the above would do nothing at all, then we convert variable-width to fixed-width. The UI is then reasonably intuitive: select strokes, click the thickness button you want once to "re-thicken" proportionally (keeping variable width), click a second time to "flatten" the widths to the nominal brush. Don't bother implementing this now unless you feel strongly like doing it -- if/when I incorporate things into master I can implement this mechanism. (On the other hand, what I'm saying is: don't create an extra config option, since I feel none is needed). Best, Denis On 12/03/2015 09:05 AM, dmg wrote: > I have fixed this and an "annoyance". > > when one selects one or more strokes with variable width and resets > their width, it would change them from variable-width to fixed-width. > This code fixes that. One issues is that there is no way now to change > strokes from variable-width to fixed-width. One way to do this would be > to add a menu option (I see this as less frequent than resizing the > width of the stroke). > > I have also created a branch that includes this fixed only: > > https://github.com/dmgerman/xournal/tree/fix-update-width > > On Wed, Dec 2, 2015 at 12:54 PM, Florian Bruhin <m...@the-compiler.org > <mailto:m...@the-compiler.org>> wrote: > > * dmg <d...@turingmachine.org <mailto:d...@turingmachine.org>> > [2015-12-02 12:28:38 -0800]: > > it is world readable? > > Yep: > -rw-r--r-- 1 root root 212941 Dec 2 21:01 /usr/share/xournal/xournal.ui > > Looking at strace xournal, it only checks ./xournal.ui and > ./../xournal.ui, but doesn't actually check in /usr/share like it > says. > > Florian > > -- > http://www.the-compiler.org | m...@the-compiler.org > <mailto:m...@the-compiler.org> (Mail/XMPP) > GPG: 916E B0C8 FD55 A072 | http://the-compiler.org/pubkey.asc > I love long mails! | http://email.is-not-s.ms/ > > > > > -- > --dmg > > --- > Daniel M. German > http://turingmachine.org > > > ------------------------------------------------------------------------------ > Go from Idea to Many App Stores Faster with Intel(R) XDK > Give your users amazing mobile app experiences with Intel(R) XDK. > Use one codebase in this all-in-one HTML5 development environment. > Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. > http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140 > > > > _______________________________________________ > Xournal-devel mailing list > Xournal-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/xournal-devel > -- Denis Auroux UC Berkeley, Department of Mathematics 817 Evans Hall, Berkeley CA 94720-3840, USA aur...@math.berkeley.edu ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140 _______________________________________________ Xournal-devel mailing list Xournal-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xournal-devel
