On 09/13/2016 12:40 PM, Immi Halupczok wrote: > I guess the different-xournal-versions-using-same-config-file is the > strongest argument I have (unless one also counts "I'm horrified of > 1,5", which probably is my real motivation ;-) ). If you think that > argument is not strong enough, then let's leave it as it is.
You have a very good point. Since the fix for bug #161 is more recent than official 0.4.8 release, we even get to change this and claim that no "official" release version ever had 1,5 in the config file. So: keep the cleanup_numeric() in parse_keyval... for people who already have recent versions with the locale-dependent config files (I suspect there must be a number by now, it's been a year...), but fix the issue when the file is being written. Turns out it seems to be very easy: add a setlocale(LC_NUMERIC, "C"); at the start of the file-writing code and setlocale(LC_NUMERIC, ""); at the end. This is already what we do when writing a .xoj file. See latest git commit in the sourceforge repository. It shouldn't break anything else, but please test (non-german speakers can do it by setting LC_NUMERIC=de_DE before starting xournal). Best, Denis -- Denis Auroux UC Berkeley, Department of Mathematics 817 Evans Hall, Berkeley CA 94720-3840, USA aur...@math.berkeley.edu ------------------------------------------------------------------------------ _______________________________________________ Xournal-devel mailing list Xournal-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xournal-devel
