Am 09.10.2016 um 00:55 schrieb D M German:
> Immi Halupczok twisted the bytes to say:
>
>
> Immi> Concerning -nan:
> Immi> I can confirm that normal xournal doesn't crash, next does. And I just
> Immi> tried: line-widths-optimized does not crash. (So chances are smaller
> Immi> that it's my fault ;-) )
>
> Immi
>
> It was :)
Ok, I found the bug. It has nothing to do with the -nan; instead, the
problem is that my code doesn't handle fixed-width strokes properly.
I'll fix it in a minute.
Immi
>
> it crashes here in the code to unify the first two points. See below.
>
> I have commented on your patch. Let me know what you think.
>
> #0 __memmove_avx_unaligned () at
> ../sysdeps/x86_64/multiarch/memcpy-avx-unaligned.S:244
> #1 0x000000000042053b in memmove (__len=<optimized out>, __src=<optimized
> out>, __dest=<optimized out>)
> at /usr/include/x86_64-linux-gnu/bits/string3.h:59
> #2 xoj_parser_text (context=<optimized out>, text=0xa6ec98 " \n",
> text_len=2, user_data=<optimized out>,
> error=0x7fffffffdbf8) at xo-file.c:1032
> #3 0x00007ffff550121b in g_markup_parse_context_parse () from
> /lib/x86_64-linux-gnu/libglib-2.0.so.0
> #4 0x0000000000421335 in open_journal (filename=filename@entry=0x984570
> "/tmp/test2.xoj") at xo-file.c:1166
> #5 0x0000000000414af3 in init_stuff (clOptions=0x7fffffffe150) at main.c:377
> #6 0x0000000000413a69 in main (argc=2, argv=0x7fffffffe268) at main.c:552
>
>
>
> Immi> Am 06.10.2016 um 20:01 schrieb dmg:
> >> This is the stroke that is crashing xournal:
> >>
> >> <stroke tool="pen" color="red" width="1.41">
> >> -nan -nan -nan -nan -nan -nan -nan -nan
> >> </stroke>
> >>
> >>
> >>
> >> On Thu, Oct 6, 2016 at 10:42 AM, D M German <[email protected]
> >> <mailto:[email protected]>> wrote:
> >>
> >> Romano Gtti twisted the bytes to say:
> >>
> Romano> I used the ruler a bit in the document, and yes, sometime I
> >> use it with the mouse (to underline text etc. and make big
> Romano> boxes, which are difficult to achieve with the mouse and
> >> the shpe recognizer). So maybe this was the culprit.
> >>
> Romano> BTW, I removed that stroke from the file but I am still
> >> unable to read it. Probably there is something more around. I
> Romano> think that not saving such a 0-length segment is ok, but a
> >> bit of defensive programming in reading it (like emit a
> Romano> warning and ignoring it) could be nice to have...
> >>
> >> I presume that the best method to determine the culprit is to:
> >>
> >> - decompress the file: rename to file.xoj.gz and run gunzip on it
> >> - do binary splicing of the file:
> >> - remove half, does it load? If so, it the error is in the other half.
> >> - do recursively until error found
> >>
> >> --dmg
> >>
> >>
> >>
> Romano> Romano
> >>
> Romano> Thanks for the effort
> >>
> >>
> >>
> Romano> --
> Romano> --
> Romano> Romano at http://www.rgtti.com/
> >>
> >>
> >> --
> >> Daniel M. German "Un libro es un amigo a voluntad...
> >> puede convertirse en alacena
> >> de recuerdos,en cántaro de deseos,o
> >> Germán Dehesa -> en ánfora de ensueños."
> >> http://turingmachine.org/
> >> http://silvernegative.com/
> >> dmg (at) uvic (dot) ca
> >> replace (at) with @ and (dot) with .
> >>
> >>
> >>
> >>
> >>
> >> --
> >> --dmg
> >>
> >> ---
> >> Daniel M. German
> >> http://turingmachine.org
>
> Immi>
> ------------------------------------------------------------------------------
> Immi> Check out the vibrant tech community on one of the world's most
> Immi> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> Immi> _______________________________________________
> Immi> Xournal-devel mailing list
> Immi> [email protected]
> Immi> https://lists.sourceforge.net/lists/listinfo/xournal-devel
>
> --
> Daniel M. German "In other studies you go as far as
> others have gone before you,
> -> and"
> http://turingmachine.org/
> http://silvernegative.com/
> dmg (at) uvic (dot) ca
> replace (at) with @ and (dot) with .
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Xournal-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xournal-devel
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Xournal-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xournal-devel
