Hi,

* Denis Auroux <aur...@math.berkeley.edu> [2017-03-19 22:29:12 -0400]:
> Hi Daniel (and Florian assuming he reads this mailing list),

I do ;-)

> I'm very confused. The link you give gives an error 404, I can't find 
> the original bug report anymore, and I can't reproduce the problem.

FWIW the 0.4.8 release seems to work fine for me too.

> There is a comment from Florian about the original code improperly using 
> a pointer allocated on the stack, I've been looking through the code he 
> removed/replaced and can't find the problem (+ there is another very 
> similar function create_pixmap() that was not put into question).

This turned out to be a red herring. The real reason (which I
mentioned in the GitHub issues, which are indeed turned off now?!) was
that - at least on the next branch - create_pixbuf was not declared
properly (haven't checked the details, presumably missing from the
header file? In any case, there was a compiler warning).

This caused the compiler to implicitly assume int, which happens to be
compatible with a void*, which means the code worked fine on 32bit
systems, but segfaulted on 64bit (because the returned pointer got
truncated).

Florian

-- 
http://www.the-compiler.org | m...@the-compiler.org (Mail/XMPP)
   GPG: 916E B0C8 FD55 A072 | http://the-compiler.org/pubkey.asc
         I love long mails! | http://email.is-not-s.ms/

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Xournal-devel mailing list
Xournal-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xournal-devel

Reply via email to