Ani Joshi wrote:
>
> On Mon, 17 Sep 2001, Michel [iso-8859-1] D�nzer wrote:
>
> > http://master.penguinppc.org/~daenzer/experimental/r128-vgaHW.diff
> >
> > (based on a hack by Ani Joshi) fixes this problem but may break VT
> > switching on i386. Any feedback appreciated.
>
> - vgaHWSave(pScrn, &hwp->SavedReg, VGA_SR_ALL); /* save mode, fonts, cmap */
> + if (info->VBIOS)
> + vgaHWSave(pScrn, &hwp->SavedReg, VGA_SR_ALL); /* save mode, fonts, cmap */
> + else
> + vgaHWSave(pScrn, &hwp->SavedReg, VGA_SR_MODE); /* save mode */
>
> The above hunk of your patch doesn't make sense. What does having a video
> BIOS (or the lack of) have to do with being able to save VGA fonts and
> color map? That will break boards on many platforms.
How so? I think it at least makes slightly more sense than than to guard it
with #ifdef __powerpc__, as it was in your hack.
> A lowerlevel fix to vgaHW.c is probably better, but keep in mind this is
> only for PowerMac's and not for all PPC machines.
You don't have to tell me that... I know next to nothing about VGA and I don't
intend to change that so someone else will have to do it.
--
Earthling Michel D�nzer (MrCooper)/ Debian GNU/Linux (powerpc) developer
XFree86 and DRI project member / CS student, Free Software enthusiast
_______________________________________________
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert
