On Fri, 12 Apr 2002, Marc Aurele La France wrote:
> On Fri, 12 Apr 2002, Dr Andrew C Aitchison wrote:
>
> > I'm having problems with the patch
> > xc/programs/xterm/main.c,v 3.148 2002/04/10 16:20:09 tsi
>
> OK, I'll back it out.
Thanks for changing it, but:
main.c: In function `spawn':
main.c:2958: parse error before `int'
main.c:2964: `pty_name' undeclared (first use in this function)
main.c:2964: (Each undeclared identifier is reported only once
main.c:2964: for each function it appears in.)
main.c:2965: `ptyfd' undeclared (first use in this function)
I think the problem is that line 2948
(void)setsid();
is not an initialisation.
I thought about changing
#ifdef USE_ISPTS_FLAG
if (IsPts) { /* SYSV386 supports both, which did we open? */
#endif
to
#ifdef USE_ISPTS_FLAG
if (IsPts) /* SYSV386 supports both, which did we open? */
#endif
{
(and the matching "} else {" and "}"), but I decided that this is too
much of a twisty maze of paths and would somtimes change the scope of
variables.
Maybe it is better to stick with code which has been well tested,
even though compliers warn about it ?
--
Dr. Andrew C. Aitchison Computer Officer, DPMMS, Cambridge
[EMAIL PROTECTED] http://www.dpmms.cam.ac.uk/~werdna
_______________________________________________
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert
