On Tue, 2002-07-02 at 09:36, James Ralston wrote: > On Mon, 1 Jul 2002, James Ralston wrote: > > > On 2 Jul 2002, Michel D�nzer wrote: > > > > > On Tue, 2002-07-02 at 00:17, James Ralston wrote: > > > > > > > On 1 Jul 2002, Michel D�nzer wrote: > > > > > > > > > Well, I wouldn't measure the non-triviality in lines of > > > > > code. :) It's mostly due to Kevin's cleanups of the > > > > > formatting, isn't it? > > > > > > > > Alas, it probably isn't: the Radeon X-Video patch which Keith > > > > committed on 2002-06-27 changed many parts of radeon_accel.c and > > > > radeon.h. :( > > > > > > Didn't even touch radeon_accel.c. > > > > > > > Trying to apply your patch to current CVS yields: > > > > > > > > 21 out of 36 hunks FAILED -- saving rejects to file > > > > radeon_accel.c.rej > > > > > > Kevin E. Martin cleaned the driver up a while ago. Look at the > > > rejects and you see that they are only due to formatting changes. > > > > You're correct; I was confusing radeon_accel.c and radeon_video.c. > > My bad. I'll integrate your patch into current CVS, test it, and > > make the revised version available. > > Unfortunately, not all of the changes were cosmetic. :( > > I've attached the hunks which I couldn't reconcile. There's only one > hunk which I think is still important, and it's this one: > > *************** > *** 1496,1501 **** > > ADVANCE_RING(); > > } > > > --- 1518,1524 ---- > > ADVANCE_RING(); > > + info->trans_color = -1; > } > > > > Michel, what function was this hunk trying to append to? (I suspect > it was RADEONCPSetupForSolidLine(), but it's now impossible to tell > for certain).
Yeah, but basically each SetupFor function which doesn't get a trans_color argument needs to set info->trans_color to -1. -- Earthling Michel D�nzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast _______________________________________________ Xpert mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/xpert
