Keith,
thanks for your answer, just two questions for clarification:
- Is the visual index used anywhwer later on. In line 363-368:
case PICT_TYPE_COLOR:
case PICT_TYPE_GRAY:
pFormats[f].type = PictTypeIndexed;
pFormats[f].format = PICT_FORMAT(PICT_FORMAT_BPP(format),
PICT_FORMAT_TYPE(format),
0, 0, 0, 0);
it is not used.
- Why not take it out of the vid member ?
Johannes
-----Urspr�ngliche Nachricht-----
Von: Keith Packard [mailto:[EMAIL PROTECTED]]
Gesendet: Mittwoch, 17. Juli 2002 19:11
An: [EMAIL PROTECTED]
Cc: Keith Packard
Betreff: Re: [Xpert]Is this a bug? render/picture.c line 228 and 233,
PictureCreateDe faultFormats
Around 17 o'clock on Jul 17, Johannes Rath wrote:
> > format = PICT_FORMAT (bpp, PICT_TYPE_COLOR, v, 0, 0, 0);
>
> I do not understand in the first place is why v (simply a loop index) is
> used as an parameter for PICT_FORMAT().
The visual index is passed from this line down to the creation of the
format stored in this value, so it's not (actually) a typo, but it
is a misuse of the macro. Instead, a different PICT_FORMAT macro
should be created for PICT_TYPE_COLOR/PICT_TYPE_GRAY which can hold
the entire visual index, even if the server has more than 16 visuals.
Keith Packard XFree86 Core Team HP Cambridge Research Lab
_______________________________________________
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert
