On Mon, 22 Jul 2002, Dr Andrew C Aitchison wrote:

> On Sun, 21 Jul 2002, Mark Vojkovich wrote:
> 
> > On Sun, 21 Jul 2002, Andrew C Aitchison wrote:
> > 
> > > 
> > > The color map handling code (in both the server and each driver)
> > > has lines like:
> > > 
> > >   if((1 << pVisual->nplanes) > pScreenPriv->maxColors) {
> > > 
> > > So far pVisual->nplanes, which is often equal to the depth,
> > > doesn't exceed 24*, so no problems.
> > > 
> > 
> > 
> > #define  DEPTH_TO_COLORS(d)   ((((d) - 1) << 1) | ((((d) - 1) << 1) - 1))
> 
> #define  DEPTH_TO_COLORS(d)   ( (1<< ((d)-1)) | ( (1<<((d)-1)) - 1) )

   Yes, wasn't thinking clearly.

> 
> looks good for d=32.
> 
> I guess I can put in a comment and assume that d>32 requires major 
> reworking on the server.

   The protocol doesn't allow greater than depth 32.


                        Mark.
_______________________________________________
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert

Reply via email to