David,
Just a little FYI, the one thing that is very important is that any memory
allocation scheme in agpgart forces the pages to be in the 32-bit pci
addressable range. I haven't looked at pci_alloc_consistent() at all, but
as long as it ensures that, and that the pages will never swap you should be
golden. I'm all for using the proper kernel interfaces, now that they are
available. Alan or Linus could probably better comment on this issue, since
I haven't looked at the kernel sources in awhile.
-Jeff
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf
Of David Dawes
Sent: Tuesday, September 10, 2002 10:22 PM
To: Sottek, Matthew J
Cc: '[EMAIL PROTECTED]'
Subject: Re: [Xpert]i830/i845G updates
On Tue, Sep 10, 2002 at 07:45:16PM -0700, Sottek, Matthew J wrote:
>
>David,
> You may want to consider changing the alloc_page to use
>pci_alloc_consistent()
>as is done in Alan Cox's version of the drm's. I changed the i810 one to do
>that
>in a patch sent to the drm list a couple weeks ago (Doesn't seem to be
>applied,
>I thought Jens was applying it). It looks like the alloc_page was reworked,
>but the pci_alloc_consistent() seems a cleaner way to go. (And potentially
>more correct, as I know that Alan changed it for a reason)
Hi Matt,
I saw your patch just after bringing in a related change from the
2.4.19 version of the module (to fix an oops). Switching to
pci_alloc_consistent() is on my todo list. Maybe it's appropriate
for the agpgart module to use it too? I haven't had a chance to look
at how it works yet.
>I don't know how far back the pci* functions go. Might be a compatibility
>issue.
Yes, that needs to be checked too.
David
--
David Dawes
Release Engineer/Architect The XFree86 Project
www.XFree86.org/~dawes
_______________________________________________
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert
_______________________________________________
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert
