C99 has integer types that have an exact width. For instance, uint32_t is an unsigned integer of 32 bit width. This would put the burden of making the right width integer types on the c library as opposed to the x include. I think that, if possible, getting rid of architecture magic in the include files would make them more understandable and possibly easier to port to other architectures.
Also, Xmd.h, and presumably other headers, mix "#ifdef symbol" and "#if defined(symbol)" directives. It is kinda sloppy. On Wednesday 16 October 2002 04:03 pm, Marc Aurele La France wrote: > On Wed, 16 Oct 2002, Warren Turkal wrote: > > > > Why does X not use the exact integral types in its typedefs? > > > > > > > > For instance, > > > > typedef uint32_t CARD32; > > > > instead of all the magic in Xmd.h? > > > > > > These are the ISO C 9X integer types aren't they ? > > > > > > I don't think we have got as far as completely ansi'fing the code yet, > > > never mind using C-9X features. > > > It might be a worthwhile project to make that file use C-9X when > > > available, and only then grovel deep inside systems for older > > > compilers, but basically it is a case of "if it ain't broke, don't fix > > > it". > > > > In the Xmd.h file, would it be okay to change the preprocessor directives > > to #if define(symbol) and such? > > Please post exactly what you have in mind (and what problem you're > trying solve) and we'll see. > > Marc. > > +----------------------------------+-----------------------------------+ > > | Marc Aurele La France | work: 1-780-492-9310 | > | Computing and Network Services | fax: 1-780-492-1729 | > | 352 General Services Building | email: [EMAIL PROTECTED] | > | University of Alberta +-----------------------------------+ > | Edmonton, Alberta | | > | T6G 2H1 | Standard disclaimers apply | > | CANADA | | > > +----------------------------------+-----------------------------------+ > XFree86 Core Team member. ATI driver and X server internals. > > _______________________________________________ > Xpert mailing list > [EMAIL PROTECTED] > http://XFree86.Org/mailman/listinfo/xpert -- Treasurer, GOLUM, Inc. http://www.golum.org _______________________________________________ Xpert mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/xpert
