On Tue, Oct 22, 2002 at 10:26:57PM -0400, David Dawes wrote: > On Tue, Oct 22, 2002 at 01:25:40AM +0200, Olivier Chapuis wrote: > >On Mon, Oct 21, 2002 at 04:54:26PM -0400, David Dawes wrote: > > > > [snip] > > > >I just write a patch which does this today. I think also that it is a > >good idea to have an option which allows to control the colours that > >Render preallocate. > > > > [snip] > > > >It is the first time I really read the code under Xserver so I am not > >sure I do the right things. Here what I do: > > > >I've added two new members to "the" ScreenRec structure: disableRender > >and renderColorLimit. In common/xf86Helper I've added a new function > >xf86SetRenderOptions(ScreenPtr) which setups these two members > >accordingly to the cmd line or config file option. Then, the driver > >should call xf86SetRenderOptions before it calls fbPictureInit. > > Is this implemented in a way that allows render to be enabled/disabled > on a per-screen basis? If so, it's probably OK to put that stuff into > the ScreenRec. > > >Render is disabled in fbPictureInit: if disableRender, then > >fbPictureInit do nothing and return TRUE. It seems to me that this is > >ok: the driver should works as if it has no Render support (?). At > >least this works with the vesa and neomagic drivers. > > Your description sounds reasonable to me. > > >One thing I am not really happy with is that we should add one > >line per driver. Maybe the two new members should be set in > >common/xf86Config.c (xf86HandleConfigFile). On the other hands, > >maybe some drivers will do not like to be compiled with RENDER, > >but run with renderDisabled? > > The way you're doing it the same as the way we currently handle > enabling/disabling backing store on a per-screen basis. >
Yes, I've made "NoRender" on a per-screen basis. As BackingStore, the option can be set in the top of the Screen section, in the Display subsection of the Screen section and in the Device section. > > I'd be interested to see the patch. > I will send a patch soon. Regards, Olivier _______________________________________________ Xpert mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/xpert
