On Fre, 2002-11-22 at 16:36, George Staikos wrote: > On Friday November 22 2002 07:58, Michel D�nzer wrote: > > On Don, 2002-11-21 at 18:12, George Staikos wrote: > > > Attached is a patch to uncorrupt the mouse pointer on PowerPC based > > > laptops with Radeon M9 chipsets. I'm not sure if there are other chipsets > > > that need this or not as this is the only one I have, but it fixes things > > > for me. > > > > IMHO this makes ugly code (bit masks and shifts to compensate for the > > framebuffer aperture byte swapping...) even uglier. I'd prefer disabling > > that byte swapping (as is done in the radeon Xv code and I proposed for > > ARGB cursors), using another aperture or a surface. > > I agree, it is ugly. But do we know that all the different models will > work this way? I have no docs so I was working blind.
If we disable byte swapping, it doesn't matter if the byte swapping actually works or not (as seems to be the case for you). > > Moreover, this is probably a bandaid for the real problem, which I > > suspect also causes the color problems people are experiencing with > > Radeon 9000s on big endian machines: the byte swapping doesn't seem to > > work as expected. > > I have a partial solution for this too. It seems like pixmaps were the > main things that were coming through with wrong colours, and doing a byte > swap in the setup code in radeon_driver.c fixes it, just as the comment says > it might. (I just adjusted the RGB masks and offsets) However that breaks > non-pixmap writes. I'm sure someone out there knows exactly why this is, but > I haven't had any more time to work on it. I don't quite understand, can you post a patch for these changes as well? -- Earthling Michel D�nzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast _______________________________________________ Xpert mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/xpert
