On Fri, Aug 24, 2007 at 06:44:36PM -0400, Rob Richards wrote: > Daniel Veillard wrote: > . . . > >or the gettimeofday support for such environment. Why ? > > > > I don't understand how you can suggest making change to non-MINGW build > >and related code when you seems to not be able to test those ! > > Please make your patches so that they affect *only* the environment > >you can test, that would be a first good point to increase the value of > >your patch. > > > >Daniel > > > >So you change the code if WIN32 and _MSC_VER is defined, removing > >winsock2.h. > I did some initial testing using VC 6 and had no trouble with winsock > removed. Thinking about it, all I/O is handled from libxml2 so libxslt > shouldn't have need for socket support anyways. > > As far as the gettimeofday support goes, the patch does didn't break > things but did change a couple of things: > xslutils now uses the windows perfmance counter for calculating timing > (not a bad thing and supposedly a recommended way of timing code). > xsltproc ends up using the clock function to calculate timing. > > I'm still testing and want to try a build with VS 2005, but wanted to at > least write this now as that all has to wait till Monday. Hopefully > someone with another one of the affected compilers can try it as well.
Well if you can confirm that the patch as-is doesn't generate troubles I'm just fine applying it :-) I just don't want to apply something that nobody could test ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ _______________________________________________ xslt mailing list, project page http://xmlsoft.org/XSLT/ [email protected] http://mail.gnome.org/mailman/listinfo/xslt
