Jason, please see below.
On 24.10.2011, at 00:30, Jason van Zyl wrote: > > On 2011-10-23, at 2:53 PM, Sebastian Zarnekow <[email protected]> > wrote: > >> Hi Jason, >> >> Guice will use cglib to create byte code for new classes for some scenarios. >> These classes may not be generated into an existing package but a new one >> because all our packages are signed. Therefore we had to use a patched >> version for Guice' naming strategy for such demand-created classes. > > I think that could go back to Guice itself. Seems perfectly reasonable to not > generate into a package that already exists. Package visible methods cannot be used together with Guice' AOP features. It should all work out of the box if the non-AOP package is used. > >> >> All usages of internal guice API look bogus to me and should be replaced >> with the corresponding common.collect classes. > > If you do that the Xtext will work fine with Guice 3 in Maven 3.x. Sounds promising. > >> >> Regards, >> Sebastian >> >> >> On 23.10.2011, at 20:12, Jason van Zyl wrote: >> >>> By creating a small JAR with the classes listed here: >>> >>> https://github.com/etesla/xtext-guice2-internal/tree/master/src/main/java/com/google/inject/internal >>> >>> I was able to run Xtext with Guice 3 inside Maven 3.x. These classes don't >>> look generated so maybe I encountered something different than what you are >>> describing. >>> >>> On Oct 23, 2011, at 1:52 PM, Sven Efftinge wrote: >>> >>>> Thanks. Note, that we had to patch the original code. We had to make sure >>>> that generated byte code is not put into a signed package (all our >>>> packages are signed). >>>> Sebastian, could you outline where and how you patched the code, so Jason >>>> is able to apply it to Guice 3 as well? >>>> >>>> On Oct 23, 2011, at 7:43 PM, Jason van Zyl wrote: >>>> >>>>> Ok, I will post my findings regarding running Guice 3 and Xtext. Boils >>>>> down the Xtext using some internal classes in Guice 2 that were relocated >>>>> in Guice 3. >>>>> >>>>> Jason >>>>> >>>>> On 2011-10-23, at 9:31 AM, Sebastian Zarnekow >>>>> <[email protected]> wrote: >>>>> >>>>>> Hi Jason, >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> xtext-dev mailing list >>>>> [email protected] >>>>> https://dev.eclipse.org/mailman/listinfo/xtext-dev >>>> >>>> _______________________________________________ >>>> xtext-dev mailing list >>>> [email protected] >>>> https://dev.eclipse.org/mailman/listinfo/xtext-dev >>> >>> Thanks, >>> >>> Jason >>> >>> ---------------------------------------------------------- >>> Jason van Zyl >>> Founder, Apache Maven >>> http://twitter.com/jvanzyl >>> --------------------------------------------------------- >>> >>> happiness is like a butterfly: the more you chase it, the more it will >>> elude you, but if you turn your attention to other things, it will come >>> and sit softly on your shoulder ... >>> >>> -- Thoreau >>> >>> >>> >>> >>> _______________________________________________ >>> xtext-dev mailing list >>> [email protected] >>> https://dev.eclipse.org/mailman/listinfo/xtext-dev >>
_______________________________________________ xtext-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/xtext-dev
