I've reduces warning reported during byte compile time.
I found emacs's byte compiler is very clever. It is worth to
check the output.
The rest warning are:
In tla-show-changes-buffer:
(1) xtla.el:1164:18:Warning: reference to free variable
font-lock-maximum-decoration
In tla-bookmarks-missing-parse-missing:
(2) xtla.el:2023:8:Warning: tla-bookmarks-missing-parse-missing being defined to
take 2 args, but was previously called with 1
In tla-bookmarks-missing-parse-changes:
(3) xtla.el:2056:8:Warning: tla-bookmarks-missing-parse-changes being defined to
take 2 args, but was previously called with 1
In tla-find-file-hook:
(4) xtla.el:5075:25:Warning: vc-ignore-vc-files is an obsolete variable; set
`vc-handled-backends' to nil to disable VC.
In end of data:
(5) xtla.el:5142:1:Warning: the function `some' might not be defined at runtime.
(6) xtla.el:5142:1:Warning: the following functions are not known to be defined:
tla-toggle-edit-cmd-flag, tla-bookmarks-missing-do-todolist, from,
highline-on, highline-off
Wrote /home/jet/var/xtla/lisp/xtla.elc
Matthieu, could you check (2), (3) and (5)?
Code related to (5):
(defun tla-bookmarks-missing-elem (data arg local-tree header
&optional changes-too)
...
(let ((bookmark-name
(some (lambda (bookmark)
(and (string= partner
(apply 'tla-fully-qualified-revision
(cdr (assoc 'location bookmark))))
(car bookmark)))
tla-bookmarks-alist)))
(add-to-list 'item `(missing ,local-tree ,partner ,bookmark-name))))
item)))
Code related to (1):
(when (or (and (boundp 'global-font-lock-mode)
global-font-lock-mode)
(and (boundp 'font-lock-maximum-decoration)
font-lock-maximum-decoration))
(font-lock-fontify-buffer))
Do we need to check font-lock-maximum-decoration?
I propose (or global-font-lock-mode font-lock-mode) as the replacement
condition.
(4) I'll inspect more.
(6)
(6.1) tla-toggle-edit-cmd-flag => no function. The definition is deleted?
(6.2) tla-bookmarks-missing-do-todolist => no function.The definition is
deleted?
(6.3) Code related to this item is `tla-move'. See below
(defun tla-move (from to only-id)
(interactive
(list (from (read-file-name "Move file: "
nil nil t
(file-name-nondirectory
(or (buffer-file-name) ""))))))
(6.4) highline-on, highline-off
We can ignore these two.
(It seems that highline-on and highline-off is available only xemacs.)
I'll inspect more.
Masatake YAMATO
