Hi all,
I've just done a big merge from everyone, restarted emacs and found that
the missing code doesn't quite work right. The patch causing the
problem is:
- (ewoc--node-delete (ewoc-next cookie parent-node)))
+ (tla-ewoc-delete tla-revision-list-cookie
+ (ewoc-next cookie parent-node)))
The context is:
(defun tla-bookmarks-missing-parse-missing (buffer parent-node)
(let ((cookie tla-revision-list-cookie)
revision date creator summary)
(let ((missing-buffer (with-current-buffer buffer
(clone-buffer))))
(with-current-buffer missing-buffer
[...]
(tla-ewoc-delete tla-revision-list-cookie
(ewoc-next cookie parent-node)))
(kill-buffer missing-buffer))))
`tla-ewoc-delete' doesn't quite seem to do what we want here--the form
(ewoc-next cookie parent-node) returns a pointer to the "Checking for
missing patches... node", so what this is doing is removing that
message once the source is finished being checked for patches.
Is leaving this as (ewoc--node-delete ..) a suitable solution? Any
thoughts?
Also, if we do leave it, I think:
(tla-ewoc-delete tla-revision-list-cookie
(ewoc-next cookie parent-node))
should read:
(tla-ewoc-delete cookie
(ewoc-next cookie parent-node))
because the form isn't executed in the *tla missing* buffer.
Cheers :o)
Mark
--
Mark Triggs
<[EMAIL PROTECTED]>
