During running tla star-merge, I've got some troubles.
I've inspect the xtla.el and I've tried to fix.
However, I have no convince. Please review.

*** xtla.el     2004-06-16 21:51:10.000000000 +0900
--- xtla.el.new 2004-06-16 21:49:23.000000000 +0900
***************
*** 1125,1131 ****
           (changes-buffer (or output-buffer (tla--get-buffer-create
                                              'changes root)))
           (header ""))
!     (if (or no-switch tla-switch-to-buffer-first)
          (set-buffer changes-buffer)
        (tla-switch-to-buffer changes-buffer))
      (let (buffer-read-only)
--- 1125,1131 ----
           (changes-buffer (or output-buffer (tla--get-buffer-create
                                              'changes root)))
           (header ""))
!     (if (or no-switch (not tla-switch-to-buffer-first))
          (set-buffer changes-buffer)
        (tla-switch-to-buffer changes-buffer))
      (let (buffer-read-only)

With the original code the changes-buffer is never shown if 
tla-switch-to-buffer-first is 
non-nil. I think this is unexpected behavios. Right?


***************
*** 1880,1888 ****
                                       ;;                                     
(tla--show-last--process-buffer)
                                       (tla-show-changes-buffer output)
                                       (message "tla star-merge finished")
!                                      (tla-revert-some-buffers ,to-tree))
!                         :error (lambda (output error status arguments)
!                                  (tla-show-changes-buffer output)))))
  
  (defun tla-replay (from &optional to-tree)
    (interactive (list
--- 1880,1886 ----
                                       ;;                                     
(tla--show-last--process-buffer)
                                       (tla-show-changes-buffer output)
                                       (message "tla star-merge finished")
!                                      (tla-revert-some-buffers ,to-tree)))))
  
  (defun tla-replay (from &optional to-tree)
    (interactive (list

With the original :error handler, output is processed. It is ok if the process 
exists with 0 status. However, when an error is occured, the error output is
not shown. Here I think we should use default behavior.

Reply via email to