Alan Coopersmith wrote: > Moinak Ghosh wrote: > >> I finally managed to get the entire FOX tree built over the >> weekend. I have put the hg diffs for adding the Xorg client >> programs up on my blog for lack of a better place: >> >> http://blogs.sun.com/moinakg/resource/app_diffs.txt >> >> Review comments, welcome. >> > > As a contributor, you should be able to post to cr.opensolaris.org > as well, which would seem a more appropriate place, but anywhere > should work. > > Some quick things I noticed, mostly nits: > - All the new files should be copyright 2007, not 2006 > - You don't need to copy the SCCS version info into the new files > - You reverted bdftopcf from the version I did to an older one > - X.Org has newer releases of several of those apps - xdm & xinit > are the ones I particularly noticed. >
The bdftopcf revert was a mistake, was about to send an email on that. I will fix the remaining stuff and update to newer versions. Regards, Moinak.
