Alan Coopersmith wrote: > Moinak Ghosh wrote: >> I have another set of diffs, this time for adding all the remaining >> font bundles to FOX repository: >> >> http://blogs.sun.com/moinakg/resource/font_diffs.txt >> >> Please take a look and let me know if you notice any nits. > > Looks like an extra $ here ($/opt...): > > PATH="$(PROTODIR)$(X11_DIR)/bin:$/opt/SUNWspro/bin
Um looks like a cut-n-paste error. > > in BUILD_ENV & CONFIG_ENV in a bunch of the Makefiles. > > In the longer term, I'd consider things such as CONFIG_ENV & > BUILD_ENV that are set in all the makefiles as something to > move to the shared fonts/Makefile.inc, but that doesn't have > to happen now. > These existing ones need to be updated. Regards, Moinak.
