On Tuesday 26 May 2015 18:08:20 Baolin Wang wrote:
> This patch series changes the 32-bit time types (timespec/itimerspec) to
> the 64-bit types (timespec64/itimerspec64), since 32-bit time types will
> break in the year 2038.
> 
> This patch series introduces new methods with timespec64/itimerspec64 type,
> and removes the old ones with timespec/itimerspec type for 
> posix_clock_operations
> and k_clock structure.

Looks good overall, I had two small comments to individual patches, and 
one very generic one:

> timekeeping: Introduce struct itimerspec64.
> timekeeping: Introduce current_kernel_time64().
> timekeeping: Change timekeeping_clocktai() with timespec64 type.
> hrtimer: Introduce hrtimer_get_res64().
> security: Introduce security_settime64().
> time: Introduce do_sys_settimeofday64().
> time: Introduce jiffies_to_timespec64()/timespec64_to_jiffies().
> cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime().
> posix-timers: Introduce {get,put}_timespec()/{get,put}_itimerspec().
> posix-timers: Split up timer_gettime()/timer_settime()/clock_settime()/
> clock_gettime()/clock_getres().
> posix-timers: Convert timer_gettime()/timer_settime()/clock_settime()/
> clock_gettime()/clock_getres() to timespec64/itimerspec64.
> mmtimer: Convert to timespec64/itimerspec64.
> alarmtimer: Convert to timespec64/itimerspec64.
> posix-clock: Convert to timespec64/itimerspec64.
> posix-cpu-timers: Convert to timespec64/itimerspec64.

I suggested you add those lines, but what I meant was:

> Baolin Wang (25):
>   linux/time64.h:Introduce the 'struct itimerspec64' for 64bit
>   timekeeping:Introduce the current_kernel_time64() function with
>     timespec64 type
>   time/hrtimer:Introduce hrtimer_get_res64() with timespec64 type
>   security/security: Introduce security_settime64() function with
>     timespec64 type
>   time:Introduce the do_sys_settimeofday64() function with timespec64
>     type
>   time/posix-timers:Introduce {get,put}_timespec and
>     {get,put}_itimerspec
>   posix-timers:Change the implementation for timer_gettime syscall
>     function

please replace these long one-line descriptions one the ones above,
so each of them actually fit in one line.

        Arnd
_______________________________________________
Y2038 mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/y2038

Reply via email to