On 3 June 2015 at 03:20, Thomas Gleixner <[email protected]> wrote: > On Mon, 1 Jun 2015, Baolin Wang wrote: > > > These are new helper functions that convert between a user timespec/ > > itimerspec and a kernel timespec64/itimerspec64 structure. > > These are not functions, these are macros. > > > These macros can change the types underneath from both ends and it > > will work efficiently on both 32-bit and 64-bit that can avoid the > > CONFIG_64BIT macro in syscall functions, and also it can make the > > syscall functions more simple. > > Lots of useless blurb which fails to explain WHY this works and WHY > this magically converts the types. > > And you fail to mention WHY dropping type safety is a good choice and > WHY dropping the might_fault() check is a proper thing to do. > > I also doubt the efficiency part as you replace a linear > copy_to_user() with four seperate ones for an itimerspec. > > This can be done proper with typesafe inline helpers, if you want to > spare the ifdef in the syscall implementation. > > Thanks, > > tglx >
Cause someone has complained there are so many ifdef in the syscall implementation before, so Arnd suggested me this goog idea that can avoid the ifdef macro. And will continue to modify the changelogs as your suggetion. Thanks for your comments. -- Baolin.wang Best Regards _______________________________________________ Y2038 mailing list [email protected] https://lists.linaro.org/mailman/listinfo/y2038
