Hi, Mark Thanks for your suggestion. I will improve my commit in the next version.
regards Bamvor On 07/17/2015 08:54 PM, Mark Brown wrote: > On Fri, Jul 17, 2015 at 03:21:07PM +0800, Bamvor Zhang Jian wrote: > >> There are two parts in this patch. I put them together in order >> to compile pass. > > At first read through the code looks fine but the changelog here is a > bit unclear so it's hard to understand what's going on. > >> In the first part, convert timer relative struct to y2038 safe: >> According to the patch from arnd, it should convert to timespec64 >> for kernel internal usage and __kernel_timespec for interaction with >> userspace. > > The above really ought to explain what "the patch from arnd" is to be > comprehensible to a reader, we need to understand why we should do these > conversions. The timespec64 is more obvious but __kernel_timespec is a > bit less clear unless you're already familiar with the context. > >> In the second part, convert the timer relative function to y2038 >> safe. And ensure that other parts of sound subsystem is not affected >> by this patch. > > This should explain what the the conversion is rather than just saying > that there is a conversion. > >> +#ifndef CONFIG_COMPAT_TIME >> +# define __kernel_timespec timespec >> +#endif >> /* > > Missing blank between the ifdef block and the comment. > _______________________________________________ Y2038 mailing list [email protected] https://lists.linaro.org/mailman/listinfo/y2038
