On Monday 23 November 2015 23:50:01 Amitoj Kaur Chawla wrote:
> Since aen_tv variable is not used anywhere we can remove the variable
> and the do_gettimeofday() function referencing it.
>
> This problem was found while removing 'struct timeval' from this
> driver to solve the y2038 problem for 32 bit systems.
>
> Signed-off-by: Amitoj Kaur Chawla <[email protected]>
> ---
> drivers/scsi/bfa/bfa_defs_svc.h | 1 -
> drivers/scsi/bfa/bfad_im.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/bfa/bfa_defs_svc.h b/drivers/scsi/bfa/bfa_defs_svc.h
> index 8ab7964..3dc713d 100644
> --- a/drivers/scsi/bfa/bfa_defs_svc.h
> +++ b/drivers/scsi/bfa/bfa_defs_svc.h
> @@ -1458,7 +1458,6 @@ struct bfa_aen_entry_s {
> enum bfa_aen_category aen_category;
> u32 aen_type;
> union bfa_aen_data_u aen_data;
> - struct timeval aen_tv;
> u32 seq_num;
> u32 bfad_num;
> };
> diff --git a/drivers/scsi/bfa/bfad_im.h b/drivers/scsi/bfa/bfad_im.h
> index f6c1023..6955042 100644
> --- a/drivers/scsi/bfa/bfad_im.h
> +++ b/drivers/scsi/bfa/bfad_im.h
> @@ -131,7 +131,6 @@ struct bfad_im_s {
>
> /* post fc_host vendor event */
> #define bfad_im_post_vendor_event(_entry, _drv, _cnt, _cat, _evt) do {
> \
> - do_gettimeofday(&(_entry)->aen_tv);
> \
> (_entry)->bfad_num = (_drv)->inst_no;
> \
> (_entry)->seq_num = (_cnt);
> \
> (_entry)->aen_category = (_cat);
> \
Have you checked if struct bfa_aen_entry_s is ever passed to something
outside of the driver, e.g. firmware or a user space ioctl?
If nothing relies on the layout of bfa_aen_entry_s, it's fine.
Arnd
_______________________________________________
Y2038 mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/y2038
