On Fri, Jul 6, 2018 at 4:42 AM, Arnd Bergmann <a...@arndb.de> wrote: > On Fri, Jul 6, 2018 at 1:56 AM, Deepa Dinamani <deepa.ker...@gmail.com> wrote: >> On Thu, Jul 5, 2018 at 3:21 PM, Christoph Hellwig <h...@infradead.org> wrote: >>> On Thu, Jul 05, 2018 at 02:36:00PM -0700, Deepa Dinamani wrote: >>>> defconfig, allmodconfig and nomodconfig. >>>> And hence does not inlude definitions for compat data types. >>>> >>>> Now that time syscalls are being reused in non CONFIG_COMPAT >>>> modes, include asm-generic definitions for riscv. >>>> >>>> Alternative would be to make compat_time.h to be conditional on >>>> CONFIG_COMPAT_32BIT_TIME. But, since riscv is already has an >>>> asm/compat.h include the generic version instead. >>> >>> Two comments here: >>> >>> First I think the current riscv compat.h is completely bogus. >>> As you mentioned riscv does not actually have a compat mode, so >>> having a compat.h makes no sensse at all, and the COMPAT_UTS_MACHINE >>> override which is the only thing implemented is included in that >>> statement. >> >> I was leaving the decision on how to clean up compat mode to the >> architecture maintainers. >> I wasn't sure if they were still in the middle of implementing it. > > If we only need it for 32 bit time_t, we can probably just use the > asm-generic/compat.h for now.
Ok. Will send out a v3 with asm/compat.h removed. Thanks. -Deepa _______________________________________________ Y2038 mailing list Y2038@lists.linaro.org https://lists.linaro.org/mailman/listinfo/y2038
