Hi Bruno, I tried to do some parts of the job (see rev2116). I hope there won't be any surprises (everything compiles and yade launches, but I did not test the capillary related code... Hopefully in a near future...).
As you suggested, I removed some of the useless files. CapillaryRecorder was not used at all, and ContactStressRecorder was used as a tool to compute Love stress which is already included in TriaxialStateRecorder (BTW, does it work as now written? Maybe some users could be interested). Additionally, I renamed CapillaryCohesiveLaw to CapillaryLaw and Simple...Water to Ip2_FrictMat_FrictMat_CapillaryLawPhys. Concerning this point, I am not sure if a specific functor for CapillaryLaw is needed, because Ip2_FrictMat_FrictMat_FrictPhys does exactly the same. I remember Simple...Water was used for distant interactions. Ip2_FrictMat_FrictMat_FrictPhys should be used, but with enlarged AABBs, shouldn't it? For end of files, I am sorry, but I did not see any concerned warning when I compiled... But I tried to leave the empty line (BTW, what is the numerical interest/meaning for that?). Concerning the indentation, I thought I was using tabs... I will be carefull in the future. The red telephone is picked up! Luc 2010/3/30 Bruno Chareyre <[email protected]> > Hi Luc, > > I'm cleaning a little theses days, a few questions and remarks : > 1- What is the use of having capillaryRecorder + capillaryStressRecorder + > contactStressRecorder? Aren't they doing more or less the same thing? Try to > pick one (in TTWater, only one is used right?) and we remove the others. > 2- Be carefull with end of files, it seems you tend to remove the last > empty line, which give compile warnings for everybody. > 3- Also try to be consistent with indentation, we use tabs, not spaces; and > please remove useless comments and/or empty lines when you see them. > > Thanks. > > Bruno > > > -- > _______________ > Bruno Chareyre > Associate Professor > Grenoble INP > Lab. 3SR > BP 53 - 38041, Grenoble cedex 9 - France > Tél : 33 4 56 52 86 21 > Fax : 33 4 76 82 70 43 > ________________ > > > _______________________________________________ > Mailing list: > https://launchpad.net/~yade-dev<https://launchpad.net/%7Eyade-dev> > Post to : [email protected] > Unsubscribe : > https://launchpad.net/~yade-dev<https://launchpad.net/%7Eyade-dev> > More help : https://help.launchpad.net/ListHelp >
_______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
