Hi Bruno, You are totally right, as I said, CFpm does exactly the same as CFCL (except the creep related to snow tests and the flags named after "erosion"). The only difference is that CFpm gathers all the interaction dispatchers in a unique file which is, in my opinion, really more readable than the separated files linked to CFCL (In fact, I did it also to help Tieng with his contact law which now works ;-) ).
I totally agree with you concerning the potential issues linked to the duplication of some files (BTW, I am curious about the pbs you fixed in CFCL?), as well as with the naming conflict, but, what is the "right" way? With CFpm, I just tried to follow the last code updates, according to Vaclav's work. CFpm was created as a way to update CFCL in its most basic form (no creep or erosion flags)... So, do we include your features to CFpm, or do we simply delete CFpm? I don't know... Luc 2010/4/19 Bruno Chareyre <[email protected]> > Hi Luc (Sc), > > I had a look at CohesiveFrictionalPM while renaming and fixing stuff. > It seems you just copied CohesiveFrictionalContactLaw and changed a few > lines. Can't it be all include in the same class? What is the difference? > > It would be better to avoid this when possible. Currently, we have > CundallStrack which is a copy of ElasticContactLaw by Boon, CFPM a copy of > CFCL by yourself, not mentionning a few others. > This practice is duplicating the potential problems from existing code to > new classes, and makes them even harder to fix when they are spreaded > everywhere (I just fixed potential problems in CFCL, but I didn't fix them > in CFPM). It also result in naming conflicts : how to reflect the difference > between a CF "contactLaw" and a CF "particleModel"? > > Bruno > > > > -- > _______________ > Bruno Chareyre > Associate Professor > Grenoble INP > Lab. 3SR > BP 53 - 38041, Grenoble cedex 9 - France > Tél : 33 4 56 52 86 21 > Fax : 33 4 76 82 70 43 > ________________ > > > _______________________________________________ > Mailing list: > https://launchpad.net/~yade-dev<https://launchpad.net/%7Eyade-dev> > Post to : [email protected] > Unsubscribe : > https://launchpad.net/~yade-dev<https://launchpad.net/%7Eyade-dev> > More help : https://help.launchpad.net/ListHelp >
_______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
