I'm replying in this thread to a commit by Vaclav. To get all discussion centered in single place.
Janek Kozicki said: (by the date of Thu, 3 Jun 2010 02:18:42 +0200) > Anton Gladky said: (by the date of Wed, 2 Jun 2010 07:32:59 +0200) > > > > - state->ori=Quaternionr(R_g2c); > > > + state->ori=Quaternionr(R_g2c); state->ori.normalize(); a minimum safety, would be performing normalization in the constructor. and LOG_WARN if constructor had to normalize a quaternion which was way off 1.0 length. Such minimum safety would make such commit as that above one to be unnecessary. But even adding normalization in the constructor requires changing eigen's implementation of quaternions. And that's an external library. So.... either contact the library authors, or derive from it another class unit_quatenrion. In fact I wonder - we could ask library authors if they are using quaternions for anything else than rotations. If not - then they might be interested in implementing in their library a unit_quaternion on top of quaternion class. -- Janek Kozicki http://janek.kozicki.pl/ | _______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
