> Do you observe some problems with this commit? Mostly a memory leak, since the size of the vector is increasing forever, and many other vectors alike. For instance: https://github.com/yade/trunk/blob/5776b8923372d9e7563dee0756d4224f01a954a8/pkg/common/InsertionSortCollider.cpp#L234
Also maybe bad performances in parallel sections, the collider especially but not only, if the first 99% of scene.bodies are occupied by null pointers. Also some algorithms in Yade may assume that max id is the number of bodies, but I have no precise examples of that. The problems will remain hiden until someone use such algorithm in a simulation where bodies are erased/created. A solution would be to uncouple b.id (the position in scene.bodies) and b.label (the identifier in post-processing functions). Cheers. Bruno 2014-09-15 11:20 GMT+02:00 Bruno Chareyre <[email protected]>: >> Hi Anton, >> I'm a bit late on that one but... does it mean that the size ob O.bodies is >> increasing forever when bodies are deleted and added? >> Bruno >> >> >> On 17/07/14 10:14, [email protected] wrote: >> >> ------------------------------------------------------------ >> revno: 4086 >> committer: Anton Gladky <[email protected]> >> timestamp: Thu 2014-07-17 08:34:00 +0200 >> message: >> Disable reusing of removed body ids. >> >> Some change in BodyContainer. Previously the ids of removed >> bodies could be reused by newly created particles. It caused >> some problems, for instance, by saving in VTK file and building >> pathlines of them in ParaView. >> >> Also it could lead to some unexpected behaviour during intensive >> removal/adding particles. >> modified: >> core/BodyContainer.cpp >> core/BodyContainer.hpp >> >> >> -- >> lp:yade >> https://code.launchpad.net/~yade-pkg/yade/git-trunk >> >> Your team Yade developers is subscribed to branch lp:yade. >> To unsubscribe from this branch go to >> https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~yade-dev >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~yade-dev >> More help : https://help.launchpad.net/ListHelp >> >> >> >> -- >> _______________ >> Bruno Chareyre >> Associate Professor >> ENSE³ - Grenoble INP >> Lab. 3SR >> BP 53 >> 38041 Grenoble cedex 9 >> Tél : +33 4 56 52 86 21 >> Fax : +33 4 76 82 70 43 >> ________________ >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~yade-dev >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~yade-dev >> More help : https://help.launchpad.net/ListHelp >> > _______________________________________________ > Mailing list: https://launchpad.net/~yade-dev > Post to : [email protected] > Unsubscribe : https://launchpad.net/~yade-dev > More help : https://help.launchpad.net/ListHelp -- _______________ Bruno Chareyre Associate Professor ENSE³ - Grenoble INP Lab. 3SR BP 53 38041 Grenoble cedex 9 Tél : +33 4 56 52 86 21 Fax : +33 4 76 82 70 43 ________________ _______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
