Ok, I guess they started from a non-up to date version, because in the end, it reverts change from (*). I'm re-reverting.
(*) https://github.com/yade/trunk/commit/ab91b3cf8654f6d563dede10184e784a8ce84219 ________________________________________ From: Yade-dev [[email protected]] on behalf of Bruno Chareyre [[email protected]] Sent: October 11, 2014 12:52 AM To: [email protected] Subject: Re: [Yade-dev] [Branch ~yade-pkg/yade/git-trunk] Rev 3461: DFNFlow unblock cells as fractures reach them + additional attributes in JCFPM I have no idea Jerome, I was only applying changes from Luc or Timos on trunk. Bruno On 10/10/14 18:43, Jerome Duriez wrote: > Hi, > > I have one pure curiosity question : apparently you let JCFpm Law include the > use of neverErase flag, why ? Are you planning to perform unsaturated > simulations with this model ? > > And, another more "important" remark about > https://github.com/yade/trunk/commit/ce10609c0a54d56dd653c895673a6857571869aa#diff-c3a96b5b91e0c2640c2009d1690df471R62 > (l.62 of JCFPM.cpp) > You typed that for "onJoint" interactions : "and normal of the interaction is > re-oriented". > Whereas I typed "Furthermore, the normal of the interaction may be > re-oriented (see > :yref:`Law2_ScGeom_JCFpmPhys_JointedCohesiveFrictionalPM.smoothJoint`" > > I think the previous sentence does better reflect the behaviour (because > normal is oriented if and only if smoothJoint is true), what do you think ? > > Thanks ! > > Jerome > ________________________________________ > From: Yade-dev > [[email protected]] on behalf of > [email protected] [[email protected]] > Sent: October-09-14 6:37 PM > To: Yade developers > Subject: [Yade-dev] [Branch ~yade-pkg/yade/git-trunk] Rev 3461: DFNFlow > unblock cells as fractures reach them + additional attributes in JCFPM > > ------------------------------------------------------------ > revno: 3461 > committer: Bruno Chareyre <[email protected]> > timestamp: Thu 2014-10-09 23:03:29 +0200 > message: > DFNFlow unblock cells as fractures reach them + additional attributes in > JCFPM > modified: > pkg/dem/JointedCohesiveFrictionalPM.cpp > pkg/dem/JointedCohesiveFrictionalPM.hpp > pkg/pfv/DFNFlow.cpp > > > -- > lp:yade > https://code.launchpad.net/~yade-pkg/yade/git-trunk > > Your team Yade developers is subscribed to branch lp:yade. > To unsubscribe from this branch go to > https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription > > _______________________________________________ > Mailing list: https://launchpad.net/~yade-dev > Post to : [email protected] > Unsubscribe : https://launchpad.net/~yade-dev > More help : https://help.launchpad.net/ListHelp > > > -- _______________ Bruno Chareyre Associate Professor ENSE³ - Grenoble INP Lab. 3SR BP 53 38041 Grenoble cedex 9 Tél : +33 4 56 52 86 21 Fax : +33 4 76 82 70 43 ________________ _______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
