On 29/10/14 01:31, Jerome Duriez wrote: > Hi, > > * CapillaryPhys/MindlinPhys.isBroken is a bool attribute that is false > by default, never updated, and never usefully used neither in c++ nor > py files of source. Furthermore, its meaning according to the doc > seems quite redundant with "meniscus". Do you agree if I remove it ? > (it = isBroken) > Ok.
> * Furthermore, the design of "meniscus" itself might maybe be > improved. Around l. 119 [1], this bool is set to true as soon as > there is contact, or if distantMeniscii should be created > And, around l.149 [2], it is set to false when volume is zero. What is wrong here? meniscus is true when there is a meniscus (i.e. a finite volume). > This seems to me contradictory (zero volume meniscii might "form" > between contacting spheres depending on the succion) and, associated > to the test l.139 [3], it leads, in some cases, to interactions that > are never deleted, even if there is no more geometrical overlap > neither a meniscus with a non-zero amount of water (because erase on > l.160 might be switched). I don't see the problem. Can you please show how to get these non-erased interactions? Cheers. Bruno
_______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
