Hi Jan, thanks for you comments.
add 2): I think a file for every shape is probably an overkill. Or anyone disagrees? I would keep general stuff like sphere, facet, box, wall in utils.py and use separate modules for polyhedra and gridpfacet as they are very specific. Regarding the latter, I think grids and pfacets should be one module because the concept is the same, i.e., a pfacet is a grid with closed openings. The latest trunk version already includes this module (py/gridpfacet.py). Finally, I think the polyhedra stuff in utlis.py should be moved into polyhedra_utils.py. You agree? Thanks Klaus On Thu, 10 Dec 2015 11:00:28 PM Jan Stránský wrote: > Hi Klaus, > > 1) no problem > 2) the logic is that the original author Jan Elias made polyhedra_utils.py > file and then I made modifications of utils.py, adding sphere() like > function for polyhedra. I was thinkink about creating special file just for > different shapes (sphere, facet, polyhedra, box, wall...), but never did > it. Still I think it is a good idea. Anyway any file split is ok for me.. > > cheers > Jan > > 2015-12-08 7:30 GMT+01:00 Klaus Thoeni <klaus.tho...@gmail.com>: > > Hi guys, > > > > I am about to push the pfacet code (as a Xmas present) but before I wanted > > to > > discuss the following: > > > > 1) The utils module is massive and I suggest that we move everything > > related > > to cylinder, grids and pfacets in a new file, e.g. gridpfacet_utils.py. > > Are you > > happy if I chance this? > > > > 2) Something similar seems already to exist for the polyhedra. However, > > there > > are still some polyhedra functions in utils.py. Wouldn't it make sense to > > move > > them as well into polyhedra_utils.py? @Jan, what is the logic behind this? > > > > 3) @Bruno: Is the chainedCylinder going to die or are we still keeping it? > > The > > implementation of the contact law for the connection/chain seems not to be > > exactly the same as for gridConnection, as I was not able to reproduce the > > results with the same parameters. Nevertheless, the concept is the same, > > right? > > > > Cheers > > Klaus > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~yade-dev > > Post to : yade-dev@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~yade-dev > > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : yade-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
