Good one, thanks. The shape test is, I think, ok. The only problem is that it may in fact accept something such as a wall-wall interaction, it would be better to test geometryIndex1 == geometryIndex2 == sphereIndex. Bruno
On 17 October 2016 at 18:46, Jérôme Duriez <jerome.dur...@ucalgary.ca> wrote: > Hi, > > Just to give some figures about this bug: > Random examples of triaxial simulations (with 20000 spherical particles > and 6 boxes) show here ~ 45% of sphere-wall interactions that are useless > at the end of the simulation. Ie ~ 3% of the (real) interactions total > number. > > I think checking for penetrationDepth < 0 around l.95 of the code [1], > before deciding to "continue", would make sense and solve this bug. > OK ? > > Do we take the opportunity to replace the shape test [2] with something > else ? (what ? if yes) > > > Jerome > > > [1] https://github.com/yade/trunk/blob/master/pkg/dem/Law2_ > ScGeom_CapillaryPhys_Capillarity.cpp#L95 > [2] https://github.com/yade/trunk/blob/master/pkg/dem/Law2_ > ScGeom_CapillaryPhys_Capillarity.cpp#L98 > > -- > You received this bug notification because you are a member of Yade > developers, which is subscribed to Yade. > https://bugs.launchpad.net/bugs/1628273 > > Title: > Sphere - nonSphere interactions never deleted by > Law2_ScGeom_CapillaryPhys_Capillarity > > Status in Yade: > New > > Bug description: > Hi, > > Let say one performs simulation with > Law2_ScGeom_CapillaryPhys_Capillarity and > Law2_ScGeom_FrictPhys_CundallStrack.neverErase = 1 (in order to keep > menisci between separated particles) > > In such case, interactions between sphere and non spherical particles > (e.g. boundaries) are not deleted by > Law2_ScGeom_FrictPhys_CundallStrack when geometrical contact is lost, > and are neither handled (deleted because of no meniscus, in > particular) by Law2_ScGeom_CapillaryPhys_Capillarity because > Law2_ScGeom_CapillaryPhys_Capillarity simply disregards such > interaction [*]. > > And the user ends up with much more interactions than necessary.. > > I'm filling a Bug report for the record and possible discussion about > desired behaviour (sorry I could not provide a MWE !) > > Jerome > > [*] > https://github.com/yade/trunk/blob/master/pkg/dem/Law2_ > ScGeom_CapillaryPhys_Capillarity.cpp#L98 > > To manage notifications about this bug go to: > https://bugs.launchpad.net/yade/+bug/1628273/+subscriptions > > _______________________________________________ > Mailing list: https://launchpad.net/~yade-dev > Post to : yade-dev@lists.launchpad.net > Unsubscribe : https://launchpad.net/~yade-dev > More help : https://help.launchpad.net/ListHelp > >
_______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : yade-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
