Thanks Vasileios.
I suggest not to remove the <vector> in PB yet because it is used in the block 
generation code.  Also some variables are redundant now , e.g. JRC, JCS, 
aperture, etc, and they are for the Barton Bandis rock joint model, which is an 
important feature, but not pursued during my PhD.
If it is deleted now, later on, I suspect that someone may add it back in the 
future.

In PP, these <vectors> are not required

Boon


________________________________
From: Vasileios Angelidakis (PGR) <v.angelidak...@newcastle.ac.uk>
Sent: Saturday, February 9, 2019 2:15 AM
To: Janek Kozicki; boo...@hotmail.com
Cc: Yade developers
Subject: Re: [Yade-dev] Potential Blocks and Potential Particles - brief 
analysis of the Object Oriented C++ source code


Hi,


I will start a WIP branch to remove unused variables and functions from both 
the PB & the PP code, to make them more readable, right after I finish writing 
the documentation. Boon please let me know if you are about to do something 
similar, so we don't overlap. Any pointers to unused parts of the codes are 
welcome!


Kind Regards,


Vasileios


Vasileios Angelidakis

Post-Graduate Researcher in Geotechnical Engineering

School of Engineering, Newcastle University

Room 3.04, Drummond Building

Devonshire Terrace, Newcastle upon Tyne, NE1 7RU, UK

E: v.angelidak...@ncl.ac.uk<mailto:v.angelidak...@ncl.ac.uk> T: +44 
(0)7380317986 W: Personal Page<https://www.students.ncl.ac.uk/vangelidakis2/>

________________________________
From: Yade-dev <yade-dev-bounces+v.angelidakis2=ncl.ac...@lists.launchpad.net> 
on behalf of Janek Kozicki <janek_li...@wp.pl>
Sent: 06 February 2019 15:02:05
Cc: Yade developers
Subject: Re: [Yade-dev] Potential Blocks and Potential Particles - brief 
analysis of the Object Oriented C++ source code

Janek Kozicki said:     (by the date of Wed, 6 Feb 2019 13:53:46 +0100)

> Hi, I didn't see the reply from Vasileios on the mailing list. I see
> it only now in quote in the reply from Boon. I will answer to both.

hm. I see your email in the archive: https://lists.launchpad.net/yade-dev/
that must have been some problem with my mail server. Yes, I have
found it in spam :( I need to switch away from this wp.pl email server.

--
Janek Kozicki

_______________________________________________
Mailing list: https://launchpad.net/~yade-dev
Post to     : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~yade-dev
Post to     : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to