Some applications may lazily load code during app dispatch,
triggering LoadError or SyntaxError exceptions. Log the error and
backtrace so application maintainers can more easily notice and
diagnose problems.
Keep in mind users are likely to have performance and race condition
problems with lazy loading, and the process may still be in a bad
state due to partially-loaded code. This commit is only intended to
give application authors a chance to notice and fix or avoid
problems in the future.
Note: logging fatal exceptions by default in all threads was
proposed in ruby-core, but currently not implemented in any released
version:
https://bugs.ruby-lang.org/issues/6647
Reported-by: Lin Jen-Shin (godfat) <god...@godfat.org>
<CAA2_N1umJO12XH9r+JHnA6r=z=mwp_pqordnw65oqw2k2-i...@mail.gmail.com>
---
I'll push this over the weekend and release 1.7 from master
(proxy_pass isn't production-ready, but there's still a good deal
of small improvements going in).
lib/yahns/queue_epoll.rb | 2 +-
lib/yahns/queue_kqueue.rb | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/yahns/queue_epoll.rb b/lib/yahns/queue_epoll.rb
index 4f3289e..2875920 100644
--- a/lib/yahns/queue_epoll.rb
+++ b/lib/yahns/queue_epoll.rb
@@ -64,7 +64,7 @@ class Yahns::Queue < SleepyPenguin::Epoll::IO # :nodoc:
raise "BUG: #{io.inspect}#yahns_step returned: #{rv.inspect}"
end
end
- rescue => e
+ rescue StandardError, LoadError, SyntaxError => e
break if closed? # can still happen due to shutdown_timeout
Yahns::Log.exception(logger, 'queue loop', e)
end while true
diff --git a/lib/yahns/queue_kqueue.rb b/lib/yahns/queue_kqueue.rb
index 4176f7a..33f5f8b 100644
--- a/lib/yahns/queue_kqueue.rb
+++ b/lib/yahns/queue_kqueue.rb
@@ -72,7 +72,7 @@ class Yahns::Queue < SleepyPenguin::Kqueue::IO # :nodoc:
raise "BUG: #{io.inspect}#yahns_step returned: #{rv.inspect}"
end
end
- rescue => e
+ rescue StandardError, LoadError, SyntaxError => e
break if closed? # can still happen due to shutdown_timeout
Yahns::Log.exception(logger, 'queue loop', e)
end while true
--
EW
