A couple notes: --pep-8 is not an option
--pep8 is redundant with -p However, I'm unable to reproduce on master with pep8 version 1.3.3 as specified by tools/tests-requires: http://paste.openstack.org/raw/33604/ Are you sure you're using pep8 1.3.3 locally? ** Changed in: keystone Status: Triaged => Invalid -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Keystone. https://bugs.launchpad.net/bugs/1131490 Title: run_tests.sh pep test not catching InvocationError Status in OpenStack Identity (Keystone): Invalid Bug description: When I run openstack@plwdevstack:/opt/stack/keystone$ ./run_tests.sh -p --pep-8 it works fine and gives me no pep error. However, when I uploaded code for review, Jenkins captured a pep specific error as below: 2013-02-21 23:26:27.299 | /home/jenkins/workspace/gate-keystone-pep8$ /home/jenkins/workspace/gate-keystone-pep8/.tox/pep8/bin/pep8 --exclude=.venv,.tox,dist,doc,openstack,vendor,*egg --repeat --show-source . 2013-02-21 23:26:31.284 | ./tests/test_backend_ldap.py:376:9: E128 continuation line under-indented for visual indent 2013-02-21 23:26:31.284 | self.identity_api.get_group, group['id']) 2013-02-21 23:26:31.284 | ^ 2013-02-21 23:26:31.292 | ERROR: InvocationError: '/home/jenkins/workspace/gate-keystone-pep8/.tox/pep8/bin/pep8 --exclude=.venv,.tox,dist,doc,openstack,vendor,*egg --repeat --show-source .' 2013-02-21 23:26:31.293 | ___________________________________ summary ____________________________________ 2013-02-21 23:26:31.293 | ERROR: pep8: commands failed where in the test_backend_ldap.py I had self.assertRaises(exception.GroupNotFound, self.identity_api.get_group, group['id']) I verified that running " ./run_tests.sh -p --pep-8" was catching different types of pep-8 specific errors (e.g. indentation error) except above one. To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1131490/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
