Reviewed: https://review.openstack.org/25738 Committed: http://github.com/openstack/nova/commit/73f580449dd68a9bbfe4455788b62bf49210d348 Submitter: Jenkins Branch: milestone-proposed
commit 73f580449dd68a9bbfe4455788b62bf49210d348 Author: Dan Smith <[email protected]> Date: Fri Mar 29 09:19:57 2013 -0700 Fix automatic confirmation of resizes for no-db-compute compute/api.py:confirm_resize() was still making a bunch of calls against the database that were tripping over the no-db-compute enforcement checks. Instead of trying to unwind all of the instance action, quota, etc code and divert to conductor, just farm out the entire confirm_resize() call to conductor. Fixes bug 1161402 Change-Id: I121040a3b575f5866d45cc8ef6862d67f5558715 (cherry picked from commit ec75cc2a6bc6e3f367b3377515cb9c4b99a6ab29) ** Changed in: nova Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1161402 Title: automatic confirmation after resize still fails Status in OpenStack Compute (Nova): Fix Released Bug description: OS: Ubuntu 12.04 OpenStack: 2013.1+git201303220742~precise-0ubuntu1 (from openstack-ubuntu-testing-grizzly-trunk-testing-precise). Similar to https://bugs.launchpad.net/nova/+bug/1152792 In resize autoconfirm nova-compute gets error: 2013-03-28 15:49:05.767 INFO nova.compute.manager [req-b4b63030-490f-4368-b403-22172f705c2d None None] Found 1 unconfirmed migrations older than 60 seconds 2013-03-28 15:49:05.768 INFO nova.compute.manager [req-b4b63030-490f-4368-b403-22172f705c2d None None] Automatically confirming migration 3 for instance 557df7f9-6d33-4cf4-9f7d-309a5731416a 2013-03-28 15:49:05.768 DEBUG nova.openstack.common.rpc.amqp [req-b4b63030-490f-4368-b403-22172f705c2d None None] Making synchronous call on conductor ... multicall /usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/amqp.py:584 2013-03-28 15:49:05.768 DEBUG nova.openstack.common.rpc.amqp [req-b4b63030-490f-4368-b403-22172f705c2d None None] MSG_ID is 212d7d8cca8a4e30baa348aad4504be5 multicall /usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/amqp.py:587 2013-03-28 15:49:05.769 DEBUG nova.openstack.common.rpc.amqp [req-b4b63030-490f-4368-b403-22172f705c2d None None] UNIQUE_ID is 15b963d02f7e4067a72883c2278392ef. _add_unique_id /usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/amqp.py:337 2013-03-28 15:49:05.861 DEBUG nova.utils [req-b4b63030-490f-4368-b403-22172f705c2d None None] Reloading cached file /etc/nova/policy.json read_cached_file /usr/lib/python2.7/dist-packages/nova/utils.py:1078 2013-03-28 15:49:05.866 ERROR nova.compute [req-b4b63030-490f-4368-b403-22172f705c2d None None] No db access allowed in nova-compute: File "/usr/lib/python2.7/dist-packages/eventlet/greenthread.py", line 192, in main result = function(*args, **kwargs) File "/usr/lib/python2.7/dist-packages/nova/utils.py", line 631, in _inner idle = self.f(*self.args, **self.kw) File "/usr/lib/python2.7/dist-packages/nova/service.py", line 571, in periodic_tasks return self.manager.periodic_tasks(ctxt, raise_on_error=raise_on_error) File "/usr/lib/python2.7/dist-packages/nova/manager.py", line 241, in periodic_tasks task(self, context) File "/usr/lib/python2.7/dist-packages/nova/compute/manager.py", line 3436, in _poll_unconfirmed_resizes migration_ref=migration) File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 163, in wrapped return func(self, context, target, *args, **kwargs) File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 153, in inner return function(self, context, instance, *args, **kwargs) File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 134, in inner return f(self, context, instance, *args, **kw) File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 1860, in confirm_resize deltas = self._downsize_quota_delta(context, migration_ref) File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 1940, in _downsize_quota_delta migration_ref['old_instance_type_id']) File "/usr/lib/python2.7/dist-packages/nova/compute/instance_types.py", line 188, in get_instance_type return db.instance_type_get(ctxt, instance_type_id) File "/usr/lib/python2.7/dist-packages/nova/db/api.py", line 1280, in instance_type_get return IMPL.instance_type_get(context, id) File "/usr/bin/nova-compute", line 66, in __call__ stacktrace = "".join(traceback.format_stack()) 2013-03-28 15:49:05.866 ERROR nova.compute.manager [req- b4b63030-490f-4368-b403-22172f705c2d None None] [instance: 557df7f9-6d33-4cf4-9f7d-309a5731416a] Error auto-confirming resize: nova-compute. Will retry later. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1161402/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
