Reviewed: https://review.openstack.org/50931 Committed: http://github.com/openstack/nova/commit/6df9225b4b03c4389c5c3920142af91d5da12924 Submitter: Jenkins Branch: milestone-proposed
commit 6df9225b4b03c4389c5c3920142af91d5da12924 Author: He Jie Xu <[email protected]> Date: Wed Oct 2 07:36:45 2013 +0800 Fix the wrong params of attach/detach interface for compute driver The reason of attach_interface failed is current code passing VIF object to attach_interface, but it expected NetworkInfo object. And as the comment of attach/detach_interface, they should only accept one interface to instance. So correct the interface signature only accept an VIF object. And correct the fake driver behavior, make the test running correctly. Change-Id: Id0d28c39fb543853bd710fcb3c3b611306b4fb8f Close-bug: #1233504 (cherry picked from commit 67414604a033413dc952c1909384340856ff9eb1) ** Changed in: nova Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1233504 Title: Attach interface to instance failed at compute manage Status in OpenStack Compute (Nova): Fix Released Bug description: When attach interface to instance, get exception from nova-compute as below: 2013-10-01 12:50:30.912 ERROR nova.openstack.common.rpc.amqp [req-7923ff3d-5f36-4b25-b686-ca05f0d14a77 admin admin] Exception during message handling 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp Traceback (most recent call last): 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/openstack/common/rpc/amqp.py", line 461, in _process_data 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp **args) 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/openstack/common/rpc/dispatcher.py", line 172, in dispatch 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp result = getattr(proxyobj, method)(ctxt, **kwargs) 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/compute/manager.py", line 3876, in attach_interface 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp self.driver.attach_interface(instance, image_meta, network_info[0]) 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/virt/libvirt/driver.py", line 1244, in attach_interface 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp self.vif_driver.plug(instance, vif) 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/virt/libvirt/vif.py", line 805, in plug 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp return self.plug_ovs_hybrid(instance, vif) 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/virt/libvirt/vif.py", line 421, in plug_ovs_hybrid 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp iface_id = self.get_ovs_interfaceid(vif) 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/virt/libvirt/vif.py", line 791, in get_ovs_interfaceid 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp return vif.get('ovs_interfaceid') or vif['id'] 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp AttributeError: 'str' object has no attribute 'get' 2013-10-01 12:50:30.912 TRACE nova.openstack.common.rpc.amqp 2013-10-01 12:50:30.972 ERROR nova.openstack.common.rpc.common [req-7923ff3d-5f36-4b25-b686-ca05f0d14a77 admin admin] Returning exception 'str' object has no attribute 'get' to caller To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1233504/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
