** Changed in: nova
Status: Incomplete => Invalid
** Changed in: nova
Status: Invalid => Opinion
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1200253
Title:
vmwareapi get_datastore_ref_and_name needs to be broken up into
get_shared_datastores and get_local_datastores
Status in OpenStack Compute (Nova):
Opinion
Bug description:
in vm_util.py method "get_datastore_ref_and_name"
The method description """Get the datastore list and choose the first
local storage.""" has the key word "and" which tends to indicate that
there is a problem in a method's design. This should probably be the
composition of two methods """Get the datastore list.""" and """choose
the first local storage.""" in the least. At best, there should be a
separate vSphere query to pull only the first local storage so that
extra data is not pulled across the wire.
See:
https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vm_util.py#L670
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1200253/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : [email protected]
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
