** Changed in: horizon
Importance: Undecided => Low
** Changed in: horizon
Status: In Progress => Fix Committed
** Changed in: horizon
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1182908
Title:
Wrong initialization of instance attributes in
horizon/tables/actions.py
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
1.
In
https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L193
the value of self.requires_input gets always filled by class attribute of the
same name defined in
https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L177
so it never takes the value from parameter given in initializer
It can be easily fixed, it is already in the right format e.g here
https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L185
This could be in more places. So maybe checking the code for this kind
of bug would be good.
2.
Also, I have noticed some unused class attributes e.g.
https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L349
Would be good to delete those.
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1182908/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : [email protected]
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
