Public bug reported: Initially Horizon only supported VNC. As support for new console types was added, the code was expanded for each console without necessarily looking at the whole, and now the code could use a bit of freshening up. This is particularly obvious in tabs.py.
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tabs.py#L55 >From a comment on https://review.openstack.org/#/c/44257/ : "We should have a common Console class that's aware of the different types, and a common means of detecting which console type to use for the instance rather than the chain of try/except statements." ** Affects: horizon Importance: Medium Status: New ** Description changed: Initially Horizon only supported VNC. As support for new console types was added, the code was expanded for each console without necessarily looking at the whole, and now the code could use a bit of freshening up. This is particularly obvious in tabs.py. https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tabs.py#L55 + + + From a comment on https://review.openstack.org/#/c/44257/ : + + "We should have a common Console class that's aware of the different + types, and a common means of detecting which console type to use for the + instance rather than the chain of try/except statements." -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1287881 Title: Refactor code around Console support Status in OpenStack Dashboard (Horizon): New Bug description: Initially Horizon only supported VNC. As support for new console types was added, the code was expanded for each console without necessarily looking at the whole, and now the code could use a bit of freshening up. This is particularly obvious in tabs.py. https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tabs.py#L55 From a comment on https://review.openstack.org/#/c/44257/ : "We should have a common Console class that's aware of the different types, and a common means of detecting which console type to use for the instance rather than the chain of try/except statements." To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1287881/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
