Oh and this should be fixed in Nova now!
** Summary changed:
- Cleaning on failed spawn in driver may override original exception
+ Cleaning on failed spawn in Ironic driver may override original exception
** Also affects: nova
Importance: Undecided
Status: New
** Tags added: ironic
** Changed in: ironic
Status: In Progress => Invalid
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1325905
Title:
Cleaning on failed spawn in Ironic driver may override original
exception
Status in OpenStack Bare Metal Provisioning Service (Ironic):
Invalid
Status in OpenStack Compute (Nova):
New
Bug description:
In Nova driver we have the following code:
# trigger the node deploy
try:
icli.call("node.set_provision_state", node_uuid,
ironic_states.ACTIVE)
except (exception.NovaException, # Retry failed
ironic_exception.InternalServerError, # Validations
ironic_exception.BadRequest) as e: # Maintenance
msg = (_("Failed to request Ironic to provision instance "
"%(inst)s: %(reason)s") % {'inst': instance['uuid'],
'reason': str(e)})
LOG.error(msg)
self._cleanup_deploy(node, instance, network_info)
raise exception.InstanceDeployFailure(msg)
If exception happens inside _cleanup_deploy, it will hide the original
one. excutils.save_and_reraise_exception() should be used here.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ironic/+bug/1325905/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
