** Changed in: glance
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1230127
Title:
Use self.assertTrue instead of self.assertEqual(..., True)
Status in OpenStack Image Registry and Delivery Service (Glance):
Fix Released
Bug description:
$ find . -name '*.*' | xargs grep self.assertEqual | grep True
./tests/integration/legacy_functional/test_v1_api.py:
self.assertEqual(data['image']['is_public'], True)
./tests/integration/legacy_functional/test_v1_api.py:
self.assertEqual(data['image']['is_public'], True)
./tests/integration/legacy_functional/test_v1_api.py:
self.assertEqual(data['image']['is_public'], True)
./tests/integration/legacy_functional/test_v1_api.py:
self.assertEqual(response['x-image-meta-is_public'], 'True')
./tests/integration/legacy_functional/test_v1_api.py:
self.assertEqual(data['image']['is_public'], True)
./tests/integration/legacy_functional/test_v1_api.py:
self.assertEqual(data['image']['is_public'], True)
./tests/integration/legacy_functional/test_v1_api.py:
self.assertEqual(data['image']['is_public'], True)
...
./tests/unit/test_swift_store.py:
self.assertEqual(connection.insecure, True)
./tests/unit/test_swift_store.py: self.assertEquals(connection.snet,
True)
./tests/unit/test_swift_store.py: self.assertEquals(connection.snet,
True)
$ find . -name '*.*' | xargs grep self.assertTrue
./tests/unit/test_context_middleware.py:
self.assertTrue(req.context.is_admin)
./tests/unit/test_context_middleware.py:
self.assertTrue(req.context.is_admin)
...
./tests/unit/test_context_middleware.py:
self.assertTrue(req.context.is_admin)
./tests/unit/test_context_middleware.py:
self.assertTrue(req.context.read_only)
./tests/unit/test_context_middleware.py:
self.assertTrue(req.context.is_admin)
The tests assertions need to be consistent: use assertTrue/assertFalse
instead of assertEqual to test boolean values.
To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1230127/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : [email protected]
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
