Reviewed: https://review.openstack.org/127144 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3f9003270efd9ac036f3c229b36baa0bb05203bf Submitter: Jenkins Branch: proposed/juno
commit 3f9003270efd9ac036f3c229b36baa0bb05203bf Author: Russell Bryant <[email protected]> Date: Wed Oct 8 12:14:31 2014 +0000 Fix broken cert revocation Cert revocation was broken by 32b0adb591f80ad2c5c19519b4ffc2b55dbea672. os.chdir() never returns anything, so this method would always raise an exception. The proper way to handle an error from os.chdir() is to catch OSError. There were existing tests for this code, but they conveniently mocked os.chdir() to return values that are never actually returned. The tests were fixed to match the real behavior. Change-Id: I7549bb60a7d43d53d6f81eecea31cbb9720cc8b6 Closes-bug: #1376368 (cherry picked from commit c8538208da00c3b0d0646629c9d668aa69944b85) ** Changed in: nova Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1376368 Title: nova.crypto.revoke_cert always raises ProjectNotFound Status in OpenStack Compute (Nova): Fix Released Status in OpenStack Security Advisories: Won't Fix Bug description: (Marked this as a security issue for now, since cert revocation not working is pretty serious) https://github.com/openstack/nova/blob/master/nova/crypto.py#L277-L278 os.chdir *always* returns None, which means that path is always taken and the cert is never revoked To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1376368/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
