Public bug reported:

https://github.com/openstack/neutron-
lbaas/blob/b868d6d3ef0066a1ac4318d7e91b4d7a076a2e61/neutron_lbaas/drivers/haproxy/namespace_driver.py#L327

arping can take relative long time (>2 sec), while the global lock is
held.

The gratuitous arping should not block other threads.

The neutron code base already contains a `non-block` version:
https://github.com/openstack/neutron/blob/6d2794345db2d7b12502f6e7b2d99e05a85b9030/neutron/agent/linux/ip_lib.py#L732

Please do not increase  the lock held time by arping.
Consider using the send_gratuitous_arp function from the ip_lib.py .

PS.:
The same blocking arping also re-implemented in the 
neutron_lbaas/drivers/haproxy/synchronous_namespace_driver.py.

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1458913

Title:
  haproxy-driver lock is held while gratuitous arping

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  https://github.com/openstack/neutron-
  
lbaas/blob/b868d6d3ef0066a1ac4318d7e91b4d7a076a2e61/neutron_lbaas/drivers/haproxy/namespace_driver.py#L327

  arping can take relative long time (>2 sec), while the global lock is
  held.

  The gratuitous arping should not block other threads.

  The neutron code base already contains a `non-block` version:
  
https://github.com/openstack/neutron/blob/6d2794345db2d7b12502f6e7b2d99e05a85b9030/neutron/agent/linux/ip_lib.py#L732

  Please do not increase  the lock held time by arping.
  Consider using the send_gratuitous_arp function from the ip_lib.py .

  PS.:
  The same blocking arping also re-implemented in the 
neutron_lbaas/drivers/haproxy/synchronous_namespace_driver.py.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1458913/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to     : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to