Public bug reported: I thought about this while reviewing:
https://review.openstack.org/#/c/184153/6/nova/virt/libvirt/utils.py Currently the ImageMeta.disk_format field is a string field so anything can go in there, regardless of whether or not nova can handle it in the virt driver layer. http://git.openstack.org/cgit/openstack/nova/tree/nova/objects/image_meta.py#n63 It seems this would be a whitelist that we could figure out and turn into an enum, so we should do that if possible. ** Affects: nova Importance: Wishlist Status: Confirmed ** Tags: unified-objects -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1489531 Title: There should be a nova.objects.fields.DiskFormatEnum for the ImageMeta.disk_format field Status in OpenStack Compute (nova): Confirmed Bug description: I thought about this while reviewing: https://review.openstack.org/#/c/184153/6/nova/virt/libvirt/utils.py Currently the ImageMeta.disk_format field is a string field so anything can go in there, regardless of whether or not nova can handle it in the virt driver layer. http://git.openstack.org/cgit/openstack/nova/tree/nova/objects/image_meta.py#n63 It seems this would be a whitelist that we could figure out and turn into an enum, so we should do that if possible. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1489531/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
